[Core][Worker_Pool] Wait for prestarted-workers for the first job and disable run_on_all_workers flaky tests #31836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scv119
added
the
@author-action-required
cadedaniel
reviewed
Jan 21, 2023
Comment on lines
765
to
767
| // This is a workaround to finish driver registration after all initial workers are | ||
| // registered to Raylet if and only if Raylet is started by a Python driver and the | ||
| // job config is not set in `ray.init(...)`. |
There was a problem hiding this comment.
Under what circumstances would the raylet be started by a Python driver?
There was a problem hiding this comment.
i think only local mode (starting ray with ray.init...)
scv119
changed the title
andreapiso
pushed a commit
to andreapiso/ray
that referenced
this pull request
Jan 22, 2023
… disable run_on_all_workers flaky tests (ray-project#31836) Why are these changes needed? ray-project#30883 we changed the behavior of first driver connect to a raylet: previously the driver connection will wait for the prestarted workers to connect before returns, and after ray-project#30883 it no longer does so. This has caused some test flakiness for test_failure_4.py -k test_task_crash_after_raylet_dead_throws_node_died_error and test_ray_shutdown.py -k test_driver_dead We restore the previous behavior and fixes the test flakiness. Also ray-project#30883 added flakiness for run_functions_on_all_workers. we disable those flaky tests Signed-off-by: Andrea Pisoni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
#30883 we changed the behavior of first driver connect to a raylet: previously the driver connection will wait for the prestarted workers to connect before returns, and after #30883 it no longer does so. This has caused some test flakiness for
test_failure_4.py -k test_task_crash_after_raylet_dead_throws_node_died_errorandtest_ray_shutdown.py -k test_driver_deadWe restore the previous behavior and fixes the test flakiness.
Also #30883 added flakiness for run_functions_on_all_workers. we disable those flaky tests
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.